Issue 23687003: Fix compilation with recent MinGW64 versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23687003: Fix compilation with recent MinGW64 versions. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix compilation with recent MinGW64 versions. Don't check for WIN32 define. Use V8_OS_* macros whenever possible, and if not use _WIN32. BUG=v8:2300 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16380

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -50 lines)			Patch
M	src/arm/disasm-arm.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ast.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gdb-jit.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/disasm-mips.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/platform.h	View	4 chunks	+11 lines, -18 lines	0 comments	Download
M	src/preparser.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/v8dll-main.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/win32-headers.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Yang, PTAL at this MinGW compile fix. -- Benedikt

7 years, 3 months ago (2013-08-28 08:10:00 UTC) #1

Benedikt Meurer

7 years, 3 months ago (2013-08-28 08:35:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16380 (presubmit successful).