Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2368693002: Remove FX_BOOL from cpdf_font (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_BOOL from cpdf_font In all cases, bool can be used instead without problems. Committed: https://pdfium.googlesource.com/pdfium/+/bfe9afc2ab1d883bb036a1c3b35b429229708875

Patch Set 1 #

Patch Set 2 : Fix winbots #

Patch Set 3 : Lets try that again #

Patch Set 4 : And again #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -70 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_cidfont.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 7 chunks +11 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_truetypefont.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 3 chunks +3 lines, -3 lines 1 comment Download
M core/fpdfapi/fpdf_font/include/cpdf_font.h View 4 chunks +8 lines, -9 lines 0 comments Download
M core/fxge/ge/cfx_font.cpp View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M core/fxge/include/fx_font.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (17 generated)
npm
PTAL
4 years, 2 months ago (2016-09-23 22:40:05 UTC) #14
Lei Zhang
lgtm https://codereview.chromium.org/2368693002/diff/60001/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp File core/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right): https://codereview.chromium.org/2368693002/diff/60001/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp#newcode503 core/fpdfapi/fpdf_font/fpdf_font_cid.cpp:503: m_bLoaded = FALSE; Saving this for later?
4 years, 2 months ago (2016-09-23 23:52:39 UTC) #17
Lei Zhang
On 2016/09/23 23:52:39, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/2368693002/diff/60001/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp > File core/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right): ...
4 years, 2 months ago (2016-09-23 23:54:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368693002/60001
4 years, 2 months ago (2016-09-23 23:54:31 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 23:54:54 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/bfe9afc2ab1d883bb036a1c3b35b42922970...

Powered by Google App Engine
This is Rietveld 408576698