Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2368673002: arc: Rename UrlHandlerInfo to IntentHandlerInfo. (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, oka+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rginda+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, darin (slow to review), yamaguchi+watch_chromium.org, davemoore+watch_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Rename UrlHandlerInfo to IntentHandlerInfo. Rename the UrlHandlerInfo struct in anticipation of using it for non-URL intents. No changes to the struct itself. BUG=647802 Committed: https://crrev.com/194f8f3ea708d59f4043236e04d3e6076094b908 Cr-Commit-Position: refs/heads/master@{#420761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/arc_file_tasks.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M components/arc/common/intent_helper.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc View 3 chunks +19 lines, -19 lines 0 comments Download
M components/arc/intent_helper/link_handler_model_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/intent_helper/link_handler_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
Daniel Erat
4 years, 3 months ago (2016-09-23 21:08:14 UTC) #2
Luis Héctor Chávez
lgtm
4 years, 3 months ago (2016-09-23 21:30:23 UTC) #9
Yusuke Sato
+rickyz arc/ lgtm
4 years, 3 months ago (2016-09-23 21:40:10 UTC) #11
dcheng
mojo lgtm
4 years, 3 months ago (2016-09-23 21:53:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368673002/1
4 years, 3 months ago (2016-09-23 22:06:08 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 22:51:39 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 22:53:05 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/194f8f3ea708d59f4043236e04d3e6076094b908
Cr-Commit-Position: refs/heads/master@{#420761}

Powered by Google App Engine
This is Rietveld 408576698