Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/browser/ui/BUILD.gn

Issue 2368633002: Fix chrome/browser/ui dependency on components/translate (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chromecast_build.gni") 5 import("//build/config/chromecast_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/split_static_library.gni") 9 import("//build/split_static_library.gni")
10 import("//chrome/common/features.gni") 10 import("//chrome/common/features.gni")
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 ] 438 ]
439 439
440 # Since browser and browser_ui actually depend on each other, 440 # Since browser and browser_ui actually depend on each other,
441 # we must omit the dependency from browser_ui to browser. 441 # we must omit the dependency from browser_ui to browser.
442 # However, this means browser_ui and browser should more or less 442 # However, this means browser_ui and browser should more or less
443 # have the same dependencies. Once browser_ui is untangled from 443 # have the same dependencies. Once browser_ui is untangled from
444 # browser, then we can clean up these dependencies. 444 # browser, then we can clean up these dependencies.
445 public_deps = [ 445 public_deps = [
446 "//components/dom_distiller/core", 446 "//components/dom_distiller/core",
447 "//components/sync", 447 "//components/sync",
448 "//components/translate/content/browser",
448 "//content/public/browser", 449 "//content/public/browser",
449 ] 450 ]
450 deps = [ 451 deps = [
451 # NOTE: New dependencies should generally be added in the OS!="ios" 452 # NOTE: New dependencies should generally be added in the OS!="ios"
452 # dependencies block below, rather than here. 453 # dependencies block below, rather than here.
453 "//base", 454 "//base",
454 "//chrome:extra_resources", 455 "//chrome:extra_resources",
455 "//chrome:resources", 456 "//chrome:resources",
456 "//chrome:strings", 457 "//chrome:strings",
457 "//chrome/app:chrome_dll_resources", 458 "//chrome/app:chrome_dll_resources",
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 "//components/startup_metric_utils/browser:lib", 536 "//components/startup_metric_utils/browser:lib",
536 "//components/strings", 537 "//components/strings",
537 "//components/subresource_filter/content/browser", 538 "//components/subresource_filter/content/browser",
538 "//components/suggestions/proto", 539 "//components/suggestions/proto",
539 "//components/supervised_user_error_page", 540 "//components/supervised_user_error_page",
540 "//components/sync", 541 "//components/sync",
541 "//components/sync_sessions", 542 "//components/sync_sessions",
542 "//components/syncable_prefs", 543 "//components/syncable_prefs",
543 "//components/toolbar", 544 "//components/toolbar",
544 "//components/tracing:startup_tracing", 545 "//components/tracing:startup_tracing",
545 "//components/translate/content/browser",
546 "//components/undo", 546 "//components/undo",
547 "//components/update_client", 547 "//components/update_client",
548 "//components/upload_list", 548 "//components/upload_list",
549 "//components/url_formatter", 549 "//components/url_formatter",
550 "//components/user_manager", 550 "//components/user_manager",
551 "//components/user_prefs", 551 "//components/user_prefs",
552 "//components/variations", 552 "//components/variations",
553 "//components/variations/service", 553 "//components/variations/service",
554 "//components/version_ui", 554 "//components/version_ui",
555 "//components/web_cache/browser", 555 "//components/web_cache/browser",
(...skipping 2862 matching lines...) Expand 10 before | Expand all | Expand 10 after
3418 "passwords/passwords_model_delegate_mock.cc", 3418 "passwords/passwords_model_delegate_mock.cc",
3419 "passwords/passwords_model_delegate_mock.h", 3419 "passwords/passwords_model_delegate_mock.h",
3420 ] 3420 ]
3421 deps += [ "//chrome/test:test_support_ui" ] 3421 deps += [ "//chrome/test:test_support_ui" ]
3422 } 3422 }
3423 3423
3424 if (enable_extensions) { 3424 if (enable_extensions) {
3425 deps += [ "//extensions/browser" ] 3425 deps += [ "//extensions/browser" ]
3426 } 3426 }
3427 } 3427 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698