runtime/lib/uri_patch.dart - Issue 23686021: Add property base to the Uri class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/uri_patch.dart

Issue 23686021: Add property base to the Uri class (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments from ahe@ Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // VM implementation of Uri.	5 // VM implementation of Uri.

6 patch class Uri {	6 patch class Uri {

7 static final bool _isWindowsCached = _isWindowsPlatform;	7 static final bool _isWindowsCached = _isWindowsPlatform;

8	8

	9 /* patch */ static bool get _isWindows => _isWindowsCached;

	10

	11 /* patch */ static Uri get base => new Uri.file(_currentDirectory() + "/");

	12

9 static bool get _isWindowsPlatform native "Uri_isWindowsPlatform";	13 static bool get _isWindowsPlatform native "Uri_isWindowsPlatform";

10	14 static _currentDirectory() native "Uri_currentDirectory";
	Ivan Posva 2013/09/17 21:28:04 Why does this have to be a native method? Can't th Why does this have to be a native method? Can't this just call into the dart:io code to get the current directory? Søren Gjesse 2013/09/25 09:17:08 Done. Show quoted text On 2013/09/17 21:28:04, Ivan Posva wrote: > Why does this have to be a native method? Can't this just call into the dart:io > code to get the current directory? Done.
11 /* patch */ static bool get _isWindows => _isWindowsCached;

12 }	15 }

OLD	NEW

« runtime/lib/uri.cc ('K') | « runtime/lib/uri.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »