Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 23686006: Rename some of SamplingCircularQueue methods (Closed)

Created:
7 years, 3 months ago by yurys
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Rename some of SamplingCircularQueue methods Renamed StartDequeue -> Peek, FinishDequeue -> Remove. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16549

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -74 lines) Patch
M src/circular-queue.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/circular-queue-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/cpu-profiler.cc View 1 1 chunk +28 lines, -32 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 4 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 3 months ago (2013-09-04 14:41:32 UTC) #1
loislo
lgtm
7 years, 3 months ago (2013-09-04 14:46:15 UTC) #2
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-05 07:34:09 UTC) #3
yurys
7 years, 3 months ago (2013-09-05 10:31:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698