Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6596)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils.h

Issue 2368593002: Prevent interpretating userinfo as url scheme when editing bookmarks (Closed)
Patch Set: Fix unittest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.h b/chrome/browser/ui/bookmarks/bookmark_utils.h
index 1cb09cef183356be49180e9274bddca49ebeaf03..1a5bf29d3599fce20c987c7c997a9c80aa331c7a 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils.h
+++ b/chrome/browser/ui/bookmarks/bookmark_utils.h
@@ -53,9 +53,8 @@ void GetURLAndTitleToBookmark(content::WebContents* web_contents,
// all tabs. This is a preference modifier, not a visual modifier.
void ToggleBookmarkBarWhenVisible(content::BrowserContext* browser_context);
-// Returns a formatted version of |url| appropriate to display to a user with
-// the given |prefs|, which may be NULL. When re-parsing this URL, clients
-// should call url_formatter::FixupURL().
+// Returns a formatted version of |url| appropriate to display to a user.
+// When re-parsing this URL, clients should call url_formatter::FixupURL().
base::string16 FormatBookmarkURLForDisplay(const GURL& url);
// Returns whether the Apps shortcut is enabled. If true, then the visibility

Powered by Google App Engine
This is Rietveld 408576698