Prevent interpretating userinfo as url scheme when editing bookmarks

chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_editor_view.h"
 
 #include <string>
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 55 matching lines @@
 
   void SetTitleText(const base::string16& title) {
     editor_->title_tf_->SetText(title);
   }
 
   void SetURLText(const base::string16& text) {
     if (editor_->details_.type != BookmarkEditor::EditDetails::NEW_FOLDER)
       editor_->url_tf_->SetText(text);
   }
 
+  base::string16 GetURLText() {
+    if (editor_->details_.type != BookmarkEditor::EditDetails::NEW_FOLDER)
+      return editor_->url_tf_->text();
+
+    return base::string16();
+  }
+
   void ApplyEdits() {
     editor_->ApplyEdits();
   }
 
   void ApplyEdits(BookmarkEditorView::EditorNode* node) {
     editor_->ApplyEdits(node);
   }
 
   BookmarkEditorView::EditorNode* AddNewFolder(
       BookmarkEditorView::EditorNode* parent) {
@@ skipping 239 matching lines @@
   ApplyEdits(NULL);
 
   const BookmarkNode* other_node = model_->other_node();
   ASSERT_EQ(2, other_node->child_count());
 
   const BookmarkNode* new_node = other_node->GetChild(0);
 
   EXPECT_EQ(ASCIIToUTF16("new_a"), new_node->GetTitle());
 }
 
+// Edits the bookmark and ensures resulting URL keeps the same scheme, even
+// when userinfo is present in the URL
+TEST_F(BookmarkEditorViewTest, EditKeepsScheme) {
+  const BookmarkNode* bb_node = model_->bookmark_bar_node();
+
+  GURL script_url = GURL("http://javascript:scripttext@example.com/");

[sky, 2016/09/26 23:03:02]

It would be nice if the tests were more similar than different. For example,
here you use GURL, in the cocoa one you don't.

[elawrence, 2016/09/29 21:53:03]

Done.

+
+  CreateEditor(profile_.get(), bb_node,
+               BookmarkEditor::EditDetails::AddNodeInFolder(
+                   bb_node, 1, script_url, base::string16()),
+               BookmarkEditorView::SHOW_TREE);
+
+  // We expect only the trailing / to be trimmed when userinfo is present
+  EXPECT_EQ(ASCIIToUTF16(script_url.spec()), GetURLText() + ASCIIToUTF16("/"));
+
+  SetTitleText(ASCIIToUTF16("EditingKeepsScheme"));

[sky, 2016/09/26 23:03:02]

Make local variable (constant) so you can compare against constant on 365.

[elawrence, 2016/09/29 21:53:03]

Done.

+
+  ApplyEdits(editor_tree_model()->GetRoot()->GetChild(0));
+
+  ASSERT_EQ(4, bb_node->child_count());
+
+  const BookmarkNode* new_node = bb_node->GetChild(1);
+
+  EXPECT_EQ(ASCIIToUTF16("EditingKeepsScheme"), new_node->GetTitle());
+  EXPECT_TRUE(script_url == new_node->url());
+}
+
 // Creates a new folder.
 TEST_F(BookmarkEditorViewTest, NewFolder) {
   const BookmarkNode* bb_node = model_->bookmark_bar_node();
   BookmarkEditor::EditDetails details =
       BookmarkEditor::EditDetails::AddFolder(bb_node, 1);
   details.urls.push_back(std::make_pair(GURL(base_path() + "x"),
                                         ASCIIToUTF16("z")));
   CreateEditor(profile_.get(), bb_node, details, BookmarkEditorView::SHOW_TREE);
 
   // The url field shouldn't be visible.
@@ skipping 63 matching lines @@
   ASSERT_TRUE(tree_view()->editor() != NULL);
   tree_view()->editor()->SetText(ASCIIToUTF16("modified"));
   ApplyEdits();
 
   // Verify the new folder was added and title set appropriately.
   ASSERT_EQ(1, parent->child_count());
   const BookmarkNode* new_folder = parent->GetChild(0);
   ASSERT_TRUE(new_folder->is_folder());
   EXPECT_EQ("modified", base::UTF16ToASCII(new_folder->GetTitle()));
 }