Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc

Issue 2368583002: [NTP Snippets] Cleanups from clang-tidy (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
index 7211c9e999b0266b343d8d10440d4e54b87a0313..202c03981c07f0612725f337588ca4647cc5902a 100644
--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
@@ -32,7 +32,6 @@ using testing::ElementsAre;
using testing::IsEmpty;
using testing::Property;
using testing::Test;
-using testing::UnorderedElementsAre;
using testing::_;
namespace ntp_snippets {
@@ -77,9 +76,9 @@ void AddTabToSession(SyncedSession* session,
class FakeForeignSessionsProvider : public ForeignSessionsProvider {
public:
- ~FakeForeignSessionsProvider() override {}
+ ~FakeForeignSessionsProvider() override = default;
void SetAllForeignSessions(std::vector<const SyncedSession*> sessions) {
- sessions_ = sessions;
+ sessions_ = std::move(sessions);
change_callback_.Run();
}
@@ -146,7 +145,7 @@ class ForeignSessionsSuggestionsProviderTest : public Test {
for (const auto& kv : sessions_map_) {
sessions.push_back(kv.second.get());
}
- fake_foreign_sessions_provider_->SetAllForeignSessions(sessions);
+ fake_foreign_sessions_provider_->SetAllForeignSessions(std::move(sessions));
}
void Dismiss(const std::string& url) {
« no previous file with comments | « components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc ('k') | components/ntp_snippets/user_classifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698