[NTP Snippets] Cleanups from clang-tidy

components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h"
 
 #include <map>
 #include <utility>
 
 #include "base/callback_forward.h"
@@ skipping 14 matching lines @@
 using base::Time;
 using base::TimeDelta;
 using sessions::SerializedNavigationEntry;
 using sessions::SessionTab;
 using sessions::SessionWindow;
 using sync_sessions::SyncedSession;
 using testing::ElementsAre;
 using testing::IsEmpty;
 using testing::Property;
 using testing::Test;
-using testing::UnorderedElementsAre;
 using testing::_;
 
 namespace ntp_snippets {
 namespace {
 
 const char kUrl1[] = "http://www.fake1.com/";
 const char kUrl2[] = "http://www.fake2.com/";
 const char kUrl3[] = "http://www.fake3.com/";
 const char kUrl4[] = "http://www.fake4.com/";
 const char kUrl5[] = "http://www.fake5.com/";
@@ skipping 24 matching lines @@
   tab->timestamp = Time::Now() - age;
   tab->navigations.push_back(navigation);
 
   SessionWindow* window = GetOrCreateWindow(session, window_id);
   // The window deletes the tabs it points at upon destruction.
   window->tabs.push_back(std::move(tab));
 }
 
 class FakeForeignSessionsProvider : public ForeignSessionsProvider {
  public:
-  ~FakeForeignSessionsProvider() override {}
+  ~FakeForeignSessionsProvider() override = default;
   void SetAllForeignSessions(std::vector<const SyncedSession*> sessions) {
-    sessions_ = sessions;
+    sessions_ = std::move(sessions);
     change_callback_.Run();
   }
 
   // ForeignSessionsProvider implementation.
   void SubscribeForForeignTabChange(
       const base::Closure& change_callback) override {
     change_callback_ = change_callback;
   }
   bool HasSessionsData() override { return true; }
   std::vector<const sync_sessions::SyncedSession*> GetAllForeignSessions()
@@ skipping 46 matching lines @@
               const std::string& url,
               TimeDelta age) {
     AddTabToSession(GetOrCreateSession(session_id), window_id, url, age);
   }
 
   void TriggerOnChange() {
     std::vector<const SyncedSession*> sessions;
     for (const auto& kv : sessions_map_) {
       sessions.push_back(kv.second.get());
     }
-    fake_foreign_sessions_provider_->SetAllForeignSessions(sessions);
+    fake_foreign_sessions_provider_->SetAllForeignSessions(std::move(sessions));
   }
 
   void Dismiss(const std::string& url) {
     // The url of a given suggestion is used as the |within_category_id|.
     provider_->DismissSuggestion(provider_->MakeUniqueID(category(), url));
   }
 
   Category category() {
     return category_factory_.FromKnownCategory(KnownCategories::FOREIGN_TABS);
   }
@@ skipping 158 matching lines @@
   AddTab(0, 0, kUrl1, TimeDelta::FromMinutes(1));
   AddTab(0, 0, kUrl2, TimeDelta::FromMinutes(2));
   AddTab(0, 0, kUrl3, TimeDelta::FromMinutes(3));
   AddTab(0, 0, kUrl4, TimeDelta::FromMinutes(4));
   AddTab(0, 0, kUrl5, TimeDelta::FromMinutes(5));
   AddTab(0, 0, kUrl6, TimeDelta::FromMinutes(6));
   TriggerOnChange();
 }
 
 }  // namespace ntp_snippets