[NTP Snippets] Cleanups from clang-tidy

components/ntp_snippets/ntp_snippet.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippet.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
@@ skipping 23 matching lines @@
   return url->is_valid();
 }
 
 }  // namespace
 
 namespace ntp_snippets {
 
 NTPSnippet::NTPSnippet(const std::string& id)
     : id_(id), score_(0), is_dismissed_(false), best_source_index_(0) {}
 
-NTPSnippet::~NTPSnippet() {}
+NTPSnippet::~NTPSnippet() = default;
 
 // static
 std::unique_ptr<NTPSnippet> NTPSnippet::CreateFromChromeReaderDictionary(
     const base::DictionaryValue& dict) {
   const base::DictionaryValue* content = nullptr;
   if (!dict.GetDictionary("contentInfo", &content))
     return nullptr;
 
   // Need at least the id.
   std::string id;
@@ skipping 132 matching lines @@
   snippet->set_dismissed(proto.dismissed());
 
   for (int i = 0; i < proto.sources_size(); ++i) {
     const SnippetSourceProto& source_proto = proto.sources(i);
     GURL url(source_proto.url());
     if (!url.is_valid()) {
       // We must at least have a valid source URL.
       DLOG(WARNING) << "Invalid article url " << source_proto.url();
       continue;
     }
-    std::string publisher_name = source_proto.publisher_name();
     GURL amp_url;
     if (source_proto.has_amp_url()) {
       amp_url = GURL(source_proto.amp_url());
       DLOG_IF(WARNING, !amp_url.is_valid()) << "Invalid AMP URL "
                                             << source_proto.amp_url();
     }
 
-    snippet->add_source(SnippetSource(url, publisher_name, amp_url));
+    snippet->add_source(
+        SnippetSource(url, source_proto.publisher_name(), amp_url));
   }
 
   if (snippet->sources_.empty()) {
     DLOG(WARNING) << "No sources found for article " << snippet->id();
     return nullptr;
   }
 
   snippet->FindBestSource();
 
   return snippet;
@@ skipping 60 matching lines @@
       best_source_index_ = i;
       if (!source.amp_url.is_empty()) {
         // This is the best possible source, stop looking.
         break;
       }
     }
   }
 }
 
 }  // namespace ntp_snippets