PlzNavigate: reset NavigationRequest on user-initiated navigation commit

PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/9e542ceb2acef8ce6ed3409411c8f6bf7d17143a
Cr-Commit-Position: refs/heads/master@{#420783}

[clamy, 2016-09-23 13:39:58]

Description was changed from

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
==========

to

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-09-23 13:40:52]

Description was changed from

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-09-23 13:40:53]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-09-23 13:41:05]

@nasko: PTAL

[nasko, 2016-09-23 22:12:59]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-09-23 22:19:24]

LGTM with a nit.

https://codereview.chromium.org/2368533002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigator_impl_unittest.cc (right):

https://codereview.chromium.org/2368533002/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigator_impl_unittest.cc:1232:
ASSERT_TRUE(speculative_rfh_2);
nit: This is technically not needed, as you've checked that speculative_rfh is
non-null above. The next line comparing equality will guarantee speculative_rfh2
is also non-null.
This can lead to not needing speculative_rfh2, as you can call GetSpeculativeRFH
directly from the EXPECT_EQ macro.

[commit-bot: I haz the power, 2016-09-23 23:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:05:16]

Dry run: This issue passed the CQ dry run.

[nasko, 2016-09-23 23:20:00]

Since my nit is very minor and the CQ dryrun passed, I'll send this CL for
commit, so we can turn the bot back to green.

[nasko, 2016-09-23 23:20:05]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:20:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:26:23]

Description was changed from

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-09-23 23:26:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-23 23:29:26]

Description was changed from

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
PlzNavigate: reset NavigationRequest on user-initiated navigation commit

This CL makes it so that an ongoing navigation is reset when a
ueser-initiated same-site or a cross-site navigation commits. This
matches what we're doing when deleting the speculative RFH. This solves
the issue with
WebContentsImplTest.CrossSiteNavigationBackOldNavigationIgnored when
browser-side navigation is enabled: a navigation commits and deletes the
speculative RFH created by another navigation, which is unexpected from
the second NavigationRequest. With this fix, the NavigationRequest is
reset at the same time as the speculative RFH.

BUG=439423
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/9e542ceb2acef8ce6ed3409411c8f6bf7d17143a
Cr-Commit-Position: refs/heads/master@{#420783}
==========

[commit-bot: I haz the power, 2016-09-23 23:29:27]

Patchset 1 (id:??) landed as
https://crrev.com/9e542ceb2acef8ce6ed3409411c8f6bf7d17143a
Cr-Commit-Position: refs/heads/master@{#420783}