Issue 23685004: Don't throw when there is an "onError" for int.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23685004: Don't throw when there is an "onError" for int.parse. (Closed)

Created:
7 years, 3 months ago by floitsch

Modified:
7 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't throw when there is an "onError" for int.parse. Even though the error is caught immediately we don't want "break on exception" developer tools stop at the parseInt case if there is a handler. BUG= http://dartbug.com/12776 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=27005

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	runtime/lib/integers.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	runtime/lib/integers_patch.dart	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

7 years, 3 months ago (2013-09-02 09:36:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27005 (presubmit successful).