Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: gin/public/v8_platform.h

Issue 2368483002: [gin] Add ConvertableToTraceFormatWrapper (Closed)
Patch Set: addressing jochen@ comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/v8_platform.h
diff --git a/gin/public/v8_platform.h b/gin/public/v8_platform.h
index 2dd32a055570bf2c0e985a9365eb32af27882784..6506ce4c555a728a8f1afec75d68fe580eece8eb 100644
--- a/gin/public/v8_platform.h
+++ b/gin/public/v8_platform.h
@@ -34,17 +34,19 @@ class GIN_EXPORT V8Platform : public NON_EXPORTED_BASE(v8::Platform) {
const uint8_t* GetCategoryGroupEnabled(const char* name) override;
const char* GetCategoryGroupName(
const uint8_t* category_enabled_flag) override;
- uint64_t AddTraceEvent(char phase,
- const uint8_t* category_enabled_flag,
- const char* name,
- const char* scope,
- uint64_t id,
- uint64_t bind_id,
- int32_t num_args,
- const char** arg_names,
- const uint8_t* arg_types,
- const uint64_t* arg_values,
- unsigned int flags) override;
+ uint64_t AddTraceEvent(
+ char phase,
+ const uint8_t* category_enabled_flag,
+ const char* name,
+ const char* scope,
+ uint64_t id,
+ uint64_t bind_id,
+ int32_t num_args,
+ const char** arg_names,
+ const uint8_t* arg_types,
+ const uint64_t* arg_values,
+ std::unique_ptr<v8::ConvertableToTraceFormat>* arg_convertibles,
+ unsigned int flags) override;
void UpdateTraceEventDuration(const uint8_t* category_enabled_flag,
const char* name,
uint64_t handle) override;
« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698