Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2368453003: Revert of Roll src/third_party/skia/ d7a9db644..bac104605 (12 commits). (Closed)

Created:
4 years, 3 months ago by Garrett Casto
Modified:
4 years, 1 month ago
CC:
chromium-reviews, borenet
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ d7a9db644..bac104605 (12 commits). (patchset #1 id:1 of https://codereview.chromium.org/2361143002/ ) Reason for revert: Reverting roll to see if this fixes a failing layout test for Mac (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10). Original issue's description: > Roll src/third_party/skia/ d7a9db644..bac104605 (12 commits). > > https://chromium.googlesource.com/skia.git/+log/d7a9db644496..bac104605ef3 > > $ git log d7a9db644..bac104605 --date=short --no-merges --format='%ad %ae %s' > 2016-09-22 caryclark Reland of ix for conic fuzz (patchset #1 id:1 of https://codereview.chromium.org/2361473004/ ) > 2016-09-22 caryclark Revert of fix for conic fuzz (patchset #3 id:40001 of https://codereview.chromium.org/2350263003/ ) > 2016-09-22 brianosman Add output format properties to SkImageFilter::Context > 2016-09-22 msarett Make SkColorSpaceXform::New() take bare ptrs > 2016-09-22 mtklein Run commandbuffer config on CommandBuffer Perf bots. > 2016-09-22 mtklein Clean up dead code. > 2016-09-22 cblume Is char* or uintptr_t easier to read? > 2016-09-22 benjaminwagner Add recipe support for Intel HD Graphics 530. > 2016-09-22 msarett Do not quickReject until virtual drawPatch > 2016-09-22 caryclark fix next kevin fuzz > 2016-09-22 caryclark fix for conic fuzz > 2016-09-22 caryclark speed up debug dm > > BUG=647922, 647922, 648512, 647922 > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > TBR=borenet@google.com > > Committed: https://crrev.com/15303daf52164b1354e7cd608198decb3f31e6ca > Cr-Commit-Position: refs/heads/master@{#420424} TBR=borenet@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647922, 647922, 648512, 647922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Garrett Casto
Created Revert of Roll src/third_party/skia/ d7a9db644..bac104605 (12 commits).
4 years, 3 months ago (2016-09-22 23:10:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368453003/1
4 years, 3 months ago (2016-09-22 23:11:04 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 23:11:43 UTC) #5
Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:36
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
03f3c43a4d6453f7d3b42ea1e2924f5712558a9a..5db1a76374c44b0d1339d91785f172615c683ffe
100644
--- a/DEPS
+++ b/DEPS
@@ -36,7 +36,7 @@
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling Skia
   # and whatever else without interference from each other.
-  'skia_revision': 'bac104605ef3d9a8ed0022694990f00518b809e9',
+  'skia_revision': 'd7a9db644496785100c4e61add1c9f8ed0494408',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling V8
   # and whatever else without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698