Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2368433003: Make CPDF_ColorSpace::Load() return a unique_ptr (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_ColorSpace::Load() return a unique_ptr Specialize default_delete to avoid having to say ReleaseDeleter<CPDF_ColorSpace> throughout the code. Committed: https://pdfium.googlesource.com/pdfium/+/917d24852841f4919f418076c0277d2742f961ca

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -72 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 9 chunks +48 lines, -65 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_colorspace.h View 3 chunks +19 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Lei, for review.
4 years, 3 months ago (2016-09-22 22:28:05 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2368433003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h File core/fpdfapi/fpdf_page/include/cpdf_colorspace.h (right): https://codereview.chromium.org/2368433003/diff/1/core/fpdfapi/fpdf_page/include/cpdf_colorspace.h#newcode115 core/fpdfapi/fpdf_page/include/cpdf_colorspace.h:115: struct default_delete<CPDF_ColorSpace> { Neat. Maybe we can do ...
4 years, 3 months ago (2016-09-23 01:46:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368433003/1
4 years, 3 months ago (2016-09-23 01:46:30 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:46:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/917d24852841f4919f418076c0277d2742f9...

Powered by Google App Engine
This is Rietveld 408576698