Document thrown errors during function parsing

Document thrown errors during function parsing

Other cleanup
Closes https://github.com/dart-lang/sdk/issues/27376

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/f7e6c02e225f540deabe2a86d7e51956728926e7

[kevmoo, 2016-09-27 17:59:36]

kevmoo@google.com changed reviewers:
+ mit@google.com, whesse@chromium.org

[kevmoo, 2016-09-28 15:29:24]

On 2016/09/27 17:59:37, kevmoo wrote:

Ping?

[Bill Hesse, 2016-09-28 15:35:56]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-09-28 15:35:57]

lgtm

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md#newcode25
CHANGELOG.md:25: * The VM now throws an `Error` when method compilation fails.
This allows for
should this say "catchable `Error`"?  Isn't this the main change - that it went
from non-catchable to catchable?

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md#newcode37
CHANGELOG.md:37: * Fixes a few bugs where the canceled `Future` wasn't passed
through
Check with Florian L if you aren't certain that this is the intended meaning,
rather than "the future called "cancel".

[kevmoo, 2016-09-28 17:39:50]

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md#newcode25
CHANGELOG.md:25: * The VM now throws an `Error` when method compilation fails.
This allows for
On 2016/09/28 15:35:56, Bill Hesse wrote:
> should this say "catchable `Error`"?  Isn't this the main change - that it
went
> from non-catchable to catchable?

Done.

https://codereview.chromium.org/2368413003/diff/1/CHANGELOG.md#newcode37
CHANGELOG.md:37: * Fixes a few bugs where the canceled `Future` wasn't passed
through
On 2016/09/28 15:35:56, Bill Hesse wrote:
> Check with Florian L if you aren't certain that this is the intended meaning,
> rather than "the future called "cancel".

Reverted the re-wording.

[kevmoo, 2016-09-28 18:35:27]

Description was changed from

==========
Document thrown errors during function parsing

Other cleanup
Closes https://github.com/dart-lang/sdk/issues/27376
==========

to

==========
Document thrown errors during function parsing

Other cleanup
Closes https://github.com/dart-lang/sdk/issues/27376

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f7e6c02e225f540deabe2a86d7e51956728926e7
==========

[kevmoo, 2016-09-28 18:35:29]

Committed patchset #2 (id:20001) manually as
f7e6c02e225f540deabe2a86d7e51956728926e7 (presubmit successful).