GetNativeImageDataFormat: Return PP_IMAGEDATAFORMAT_RGBA_PREMUL in the case of SK_R32_SHIFT == 0 (…

GetNativeImageDataFormat: Return PP_IMAGEDATAFORMAT_RGBA_PREMUL in the case of SK_R32_SHIFT == 0  (l-endian)

BUG=276923
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231695

[Joshuar, 2013-09-24 18:25:01]

On 2013/09/24 18:24:13, Joshuar wrote:

Not sure why there are two patch sets.

[dmichael (off chromium), 2013-09-24 19:13:02]

lgtm, thanks!

https://codereview.chromium.org/23684065/diff/3001/ppapi/shared_impl/ppb_imag...
File ppapi/shared_impl/ppb_image_data_shared.cc (right):

https://codereview.chromium.org/23684065/diff/3001/ppapi/shared_impl/ppb_imag...
ppapi/shared_impl/ppb_image_data_shared.cc:34: return
PP_IMAGEDATAFORMAT_BGRA_PREMUL;
originally, there was a comment at the end of this line:
"  // Default to something on failure."

could you put that back, please?

[Joshuar, 2013-09-24 19:18:38]

https://codereview.chromium.org/23684065/diff/3001/ppapi/shared_impl/ppb_imag...
File ppapi/shared_impl/ppb_image_data_shared.cc (right):

https://codereview.chromium.org/23684065/diff/3001/ppapi/shared_impl/ppb_imag...
ppapi/shared_impl/ppb_image_data_shared.cc:34: return
PP_IMAGEDATAFORMAT_BGRA_PREMUL;
On 2013/09/24 19:13:03, dmichael wrote:
> originally, there was a comment at the end of this line:
> "  // Default to something on failure."
> 
> could you put that back, please?

Done.

[dmichael (off chromium), 2013-09-24 19:33:56]

Sweet. Now you can check the "Commit" box on this CL and watch the Commit Queue
inaction.

(sorry, couldn't resist the pun)

[Joshuar, 2013-09-24 19:37:09]

On 2013/09/24 19:33:56, dmichael wrote:
> Sweet. Now you can check the "Commit" box on this CL and watch the Commit
Queue
> inaction.
> 
> (sorry, couldn't resist the pun)

Noob question:  Is the Commit queue rather like TAP?

[commit-bot: I haz the power, 2013-09-24 20:19:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhoak@google.com/23684065/10001

[commit-bot: I haz the power, 2013-09-24 21:36:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhoak@google.com/23684065/19001

[commit-bot: I haz the power, 2013-09-25 00:00:30]

Retried try job too often on linux_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-09-25 15:31:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhoak@google.com/23684065/19001

[commit-bot: I haz the power, 2013-09-25 17:44:30]

Retried try job too often on linux_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-10-29 18:36:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhoak@google.com/23684065/19001

[commit-bot: I haz the power, 2013-10-29 19:08:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jhoak@google.com/23684065/19001

[commit-bot: I haz the power, 2013-10-30 01:04:15]

Change committed as 231695