Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 23684042: Eliminate NetworkManagerChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | chromeos/network/network_state_handler_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index fbb75d5b9d0e9ce557c40c70cb3ca60eb73c4ae8..c8516d678dd836248685a08eae924a546c651cf8 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -131,8 +131,8 @@ void NetworkStateHandler::SetTechnologyEnabled(
base::StringPrintf("%s:%d", technology.c_str(), enabled));
shill_property_handler_->SetTechnologyEnabled(
technology, enabled, error_callback);
- // Signal Technology state changed -> ENABLING
- NotifyManagerPropertyChanged();
+ // Signal Device/Technology state changed.
+ NotifyDeviceListChanged();
}
const DeviceState* NetworkStateHandler::GetDeviceState(
@@ -557,8 +557,7 @@ void NetworkStateHandler::UpdateDeviceProperty(const std::string& device_path,
detail += " = " + network_event_log::ValueAsString(value);
NET_LOG_EVENT("DevicePropertyUpdated", detail);
- FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
- DeviceListChanged());
+ NotifyDeviceListChanged();
if (key == flimflam::kScanningProperty && device->scanning() == false)
ScanCompleted(device->type());
@@ -569,10 +568,10 @@ void NetworkStateHandler::CheckPortalListChanged(
check_portal_list_ = check_portal_list;
}
-void NetworkStateHandler::NotifyManagerPropertyChanged() {
- NET_LOG_DEBUG("NotifyManagerPropertyChanged", "");
- FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
- NetworkManagerChanged());
+void NetworkStateHandler::TechnologyListChanged() {
+ // Eventually we would like to replace Technology state with Device state.
+ // For now, treat technology state changes as device list changes.
+ NotifyDeviceListChanged();
}
void NetworkStateHandler::ManagedStateListChanged(
@@ -609,10 +608,7 @@ void NetworkStateHandler::ManagedStateListChanged(
UMA_HISTOGRAM_COUNTS_100("Networks.RememberedShared", shared);
UMA_HISTOGRAM_COUNTS_100("Networks.RememberedUnshared", unshared);
} else if (type == ManagedState::MANAGED_TYPE_DEVICE) {
- NET_LOG_DEBUG("DeviceListChanged",
- base::StringPrintf("Size:%" PRIuS, device_list_.size()));
- FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
- DeviceListChanged());
+ NotifyDeviceListChanged();
} else {
NOTREACHED();
}
@@ -621,6 +617,13 @@ void NetworkStateHandler::ManagedStateListChanged(
//------------------------------------------------------------------------------
// Private methods
+void NetworkStateHandler::NotifyDeviceListChanged() {
+ NET_LOG_DEBUG("NotifyDeviceListChanged",
+ base::StringPrintf("Size:%" PRIuS, device_list_.size()));
+ FOR_EACH_OBSERVER(NetworkStateHandlerObserver, observers_,
+ DeviceListChanged());
+}
+
DeviceState* NetworkStateHandler::GetModifiableDeviceState(
const std::string& device_path) const {
ManagedState* managed = GetModifiableManagedState(&device_list_, device_path);
« no previous file with comments | « chromeos/network/network_state_handler.h ('k') | chromeos/network/network_state_handler_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698