Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/chromeos/login/auth_prewarmer.cc

Issue 23684042: Eliminate NetworkManagerChanged (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/auth_prewarmer.cc
diff --git a/chrome/browser/chromeos/login/auth_prewarmer.cc b/chrome/browser/chromeos/login/auth_prewarmer.cc
index 3fe03a17bc8dc4b1ecd98332b08ea83d955699c0..0ebb3d5d1b1f0f3b2762dbfbbaa84aba8aba8a3e 100644
--- a/chrome/browser/chromeos/login/auth_prewarmer.cc
+++ b/chrome/browser/chromeos/login/auth_prewarmer.cc
@@ -48,9 +48,11 @@ void AuthPrewarmer::PrewarmAuthentication(
DoPrewarm();
return;
}
- if (!IsNetworkConnected())
- NetworkHandler::Get()->network_state_handler()->AddObserver(this,
- FROM_HERE);
+ if (!IsNetworkConnected()) {
+ // DefaultNetworkChanged will get called when a network becomes connected.
+ NetworkHandler::Get()->network_state_handler()
+ ->AddObserver(this, FROM_HERE);
+ }
if (!GetRequestContext()) {
registrar_.Add(
this,
@@ -59,17 +61,14 @@ void AuthPrewarmer::PrewarmAuthentication(
}
}
-void AuthPrewarmer::NetworkManagerChanged() {
- if (IsNetworkConnected()) {
- NetworkHandler::Get()->network_state_handler()->RemoveObserver(this,
- FROM_HERE);
- if (GetRequestContext())
- DoPrewarm();
- }
-}
-
void AuthPrewarmer::DefaultNetworkChanged(const NetworkState* network) {
- NetworkManagerChanged();
+ if (!network)
+ return; // Still no default (connected) network.
+
+ NetworkHandler::Get()->network_state_handler()
+ ->RemoveObserver(this, FROM_HERE);
+ if (GetRequestContext())
+ DoPrewarm();
}
void AuthPrewarmer::Observe(int type,
@@ -121,4 +120,3 @@ net::URLRequestContextGetter* AuthPrewarmer::GetRequestContext() const {
}
} // namespace chromeos
-
« no previous file with comments | « chrome/browser/chromeos/login/auth_prewarmer.h ('k') | chrome/browser/chromeos/login/screens/network_screen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698