Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 23684036: Fix large performance regression in Box2D, MD5, and SHA1 benchmarks (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 3fe8ebcba21c0a5cf80449d0083c74c00187800b..5bda426e5367beadbe44770b66f4ff4ec4c3e71d 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -1611,6 +1611,11 @@ void GuardFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
// list length here, without this check the list length could change
// without triggering a deoptimization.
Label check_array, length_compared, no_fixed_length;
+ // If length is negative the length guard is either disabled or
+ // has not been initialized, either way it is safe to skip the
+ // length check.
+ __ cmpl(field_length_operand, Immediate(Smi::RawValue(0)));
+ __ j(LESS, &skip_length_check);
__ cmpl(value_cid_reg, Immediate(kNullCid));
__ j(EQUAL, &no_fixed_length, Assembler::kNearJump);
// Check for typed data array.
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698