Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 23684035: Prepare push to trunk. Now working on version 3.21.13. (Closed)

Created:
7 years, 3 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.21.13. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16592

Patch Set 1 #

Total comments: 1

Patch Set 2 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
7 years, 3 months ago (2013-09-09 11:46:48 UTC) #1
rossberg
lgtm https://codereview.chromium.org/23684035/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/23684035/diff/1/ChangeLog#newcode3 ChangeLog:3: Fix bitwise negation on x64 Nit: Use past ...
7 years, 3 months ago (2013-09-09 11:48:01 UTC) #2
Dmitry Lomov (no reviews)
7 years, 3 months ago (2013-09-09 11:50:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698