Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: trunk/src/ppapi/api/private/ppb_nacl_private.idl

Issue 23684032: Revert 221275 "Handle cache-control:no-store header in PNaCl tra..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/components/nacl/common/pnacl_types.cc ('k') | trunk/src/ppapi/c/private/ppb_nacl_private.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ppapi/api/private/ppb_nacl_private.idl
===================================================================
--- trunk/src/ppapi/api/private/ppb_nacl_private.idl (revision 221280)
+++ trunk/src/ppapi/api/private/ppb_nacl_private.idl (working copy)
@@ -106,19 +106,18 @@
*/
PP_FileHandle CreateTemporaryFile([in] PP_Instance instance);
- /* Create a temporary file, which will be deleted by the time the
- * last handle is closed (or earlier on POSIX systems), to use for
- * the nexe with the cache information given by |pexe_url|,
- * |abi_version|, |opt_level|, |last_modified|, |etag|, and
- * |has_no_store_header|. If the nexe is already present in the
- * cache, |is_hit| is set to PP_TRUE and the contents of the nexe
- * will be copied into the temporary file. Otherwise |is_hit| is set
- * to PP_FALSE and the temporary file will be writeable. Currently
- * the implementation is a stub, which always sets is_hit to false
- * and calls the implementation of CreateTemporaryFile. In a
- * subsequent CL it will call into the browser which will remember
- * the association between the cache key and the fd, and copy the
- * nexe into the cache after the translation finishes.
+ /* Create a temporary file, which will be deleted by the time the last
+ * handle is closed (or earlier on POSIX systems), to use for the nexe
+ * with the cache information given by |pexe_url|, |abi_version|, |opt_level|,
+ * |last_modified|, and |etag|. If the nexe is already present
+ * in the cache, |is_hit| is set to PP_TRUE and the contents of the nexe
+ * will be copied into the temporary file. Otherwise |is_hit| is set to
+ * PP_FALSE and the temporary file will be writeable.
+ * Currently the implementation is a stub, which always sets is_hit to false
+ * and calls the implementation of CreateTemporaryFile. In a subsequent CL
+ * it will call into the browser which will remember the association between
+ * the cache key and the fd, and copy the nexe into the cache after the
+ * translation finishes.
*/
int32_t GetNexeFd([in] PP_Instance instance,
[in] str_t pexe_url,
@@ -126,7 +125,6 @@
[in] uint32_t opt_level,
[in] str_t last_modified,
[in] str_t etag,
- [in] PP_Bool has_no_store_header,
[out] PP_Bool is_hit,
[out] PP_FileHandle nexe_handle,
[in] PP_CompletionCallback callback);
« no previous file with comments | « trunk/src/components/nacl/common/pnacl_types.cc ('k') | trunk/src/ppapi/c/private/ppb_nacl_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698