Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 23684032: Revert 221275 "Handle cache-control:no-store header in PNaCl tra..." (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
Derek Schuff
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221275 "Handle cache-control:no-store header in PNaCl tra..." > Handle cache-control:no-store header in PNaCl translation cache > > Pexe files with the cache-control:no-store header should not be cached. > Add a field to the PnaclCacheInfo struct, plumb the value all the way > from the plugin to the browser, and treat it basically the same way we > currently treat incognito translations (since we currently don't have an > off-the-record cache for those). > R=jvoung@chromium.org > BUG=none, noticed this was missing when doing cleanup > > Review URL: https://chromiumcodereview.appspot.com/23458015 TBR=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -111 lines) Patch
M trunk/src/chrome/browser/nacl_host/pnacl_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/pnacl_host.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/nacl_host/pnacl_host_unittest.cc View 5 chunks +19 lines, -56 lines 0 comments Download
M trunk/src/chrome/renderer/pepper/ppb_nacl_private_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/common/nacl_host_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/nacl/common/pnacl_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/nacl/common/pnacl_types.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/ppapi/api/private/ppb_nacl_private.idl View 2 chunks +12 lines, -14 lines 0 comments Download
M trunk/src/ppapi/c/private/ppb_nacl_private.h View 3 chunks +13 lines, -15 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-04 22:31:34 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-04 22:31:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221281.

Powered by Google App Engine
This is Rietveld 408576698