fpdfsdk/javascript/Field.cpp - Issue 2368403002: Watch destruction of widgets around OnAAction() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Field.cpp

Issue 2368403002: Watch destruction of widgets around OnAAction() method (Closed)

Patch Set: Pass everywhere Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Field.cpp

diff --git a/fpdfsdk/javascript/Field.cpp b/fpdfsdk/javascript/Field.cpp

index 3abf0ecc7e58f6b40bc1f46e966af6c4f82a415e..499e21659c2f0c48a3f4b1a35d49b502895b14bd 100644

--- a/fpdfsdk/javascript/Field.cpp

+++ b/fpdfsdk/javascript/Field.cpp

@@ -3222,7 +3222,8 @@ FX_BOOL Field::setFocus(IJS_Context* cc,

}

if (pWidget) {

- m_pDocument->SetFocusAnnot(pWidget);

+ CPDFSDK_Annot::ObservedPtr pObserved(pWidget);

+ m_pDocument->SetFocusAnnot(pObserved);

}

return TRUE;