Watch destruction of widgets around OnAAction() method

fpdfsdk/formfiller/cffl_formfiller.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/formfiller/cffl_formfiller.h"
 
 #include "core/fpdfapi/fpdf_page/include/cpdf_page.h"
 #include "core/fxge/include/cfx_renderdevice.h"
@@ skipping 509 matching lines @@
   return rect;
 }
 
 FX_BOOL CFFL_FormFiller::CommitData(CPDFSDK_PageView* pPageView,
                                     uint32_t nFlag) {
   if (IsDataChanged(pPageView)) {
     FX_BOOL bRC = TRUE;
     FX_BOOL bExit = FALSE;
     CFFL_InteractiveFormFiller* pFormFiller =
         m_pEnv->GetInteractiveFormFiller();
-    pFormFiller->OnKeyStrokeCommit(m_pWidget, pPageView, bRC, bExit, nFlag);
+    CPDFSDK_Annot::ObservedPtr pObserved(m_pWidget);
+    pFormFiller->OnKeyStrokeCommit(pObserved, pPageView, bRC, bExit, nFlag);
+    if (!pObserved)

[Lei Zhang, 2016/09/27 17:02:22]

Combine into: if (!pObserved || bExit)

Same pattern in a bunch of other places

[Tom Sepez, 2016/09/27 20:21:08]

Ah, ok.  bExit in a few places is an out variable, there we need to be sure to
set it ... done.

+      bExit = TRUE;
     if (bExit)
       return TRUE;
     if (!bRC) {
       ResetPDFWindow(pPageView, FALSE);
       return TRUE;
     }
-
-    pFormFiller->OnValidate(m_pWidget, pPageView, bRC, bExit, nFlag);
+    pFormFiller->OnValidate(pObserved, pPageView, bRC, bExit, nFlag);
+    if (!pObserved)
+      bExit = TRUE;
     if (bExit)
       return TRUE;
     if (!bRC) {
       ResetPDFWindow(pPageView, FALSE);
       return TRUE;
     }
 
     SaveData(pPageView);
     pFormFiller->OnCalculate(m_pWidget, pPageView, bExit, nFlag);
     if (bExit)
@@ skipping 163 matching lines @@
     pWidget->DrawAppearance(pDevice, pUser2Device, CPDF_Annot::Normal, nullptr);
   }
 }
 
 void CFFL_Button::OnDrawDeactive(CPDFSDK_PageView* pPageView,
                                  CPDFSDK_Annot* pAnnot,
                                  CFX_RenderDevice* pDevice,
                                  CFX_Matrix* pUser2Device) {
   OnDraw(pPageView, pAnnot, pDevice, pUser2Device);
 }