Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: google_apis/gcm/gcm.gyp

Issue 23684017: [GCM] Initial work to set up directory structure and introduce socket integration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: StringPiece + UnreadByteCount Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/gcm.gyp
diff --git a/google_apis/gcm/gcm.gyp b/google_apis/gcm/gcm.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..dbc9601fc1fe1d543f9f34b00666af284b7efcf0
--- /dev/null
+++ b/google_apis/gcm/gcm.gyp
@@ -0,0 +1,57 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+ 'variables': {
+ 'chromium_code': 1,
+ },
+
+ 'targets': [
+ # The public GCM shared library target.
+ {
+ 'target_name': 'gcm',
+ 'type': 'shared_library',
+ 'variables': { 'enable_wexit_time_destructors': 1, },
+ 'include_dirs': [
akalin 2013/10/16 07:16:31 need include_dirs for gcm_unit_tests too?
Nicolas Zea 2013/10/16 19:56:18 Done.
+ '../..',
+ ],
+ 'defines': [
+ 'GCM_IMPLEMENTATION',
+ ],
+ 'dependencies': [
+ '../../base/base.gyp:base',
+ '../../net/net.gyp:net',
+ '../../url/url.gyp:url_lib',
akalin 2013/10/16 07:16:31 don't need to depend on url_lib yet, do you?
Nicolas Zea 2013/10/16 19:56:18 Done.
+ '../../third_party/protobuf/protobuf.gyp:protobuf_lite'
+ ],
+ 'sources': [
+ 'base/socket_stream.h',
+ 'base/socket_stream.cc',
+ ],
+ },
+
+ # The main GCM unit tests.
+ {
+ 'target_name': 'gcm_unit_tests',
+ 'type': '<(gtest_target_type)',
+ # Typed-parametrized tests generate exit-time destructors.
akalin 2013/10/16 07:16:31 we don't use type-parametrized tests yet, right? e
Nicolas Zea 2013/10/16 19:56:18 Done.
+ 'variables': { 'enable_wexit_time_destructors': 0, },
+ 'defines': [
+ 'GCM_TEST',
akalin 2013/10/16 07:16:31 don't think you need this define
Nicolas Zea 2013/10/16 19:56:18 Done.
+ ],
+ 'dependencies': [
+ '../../base/base.gyp:run_all_unittests',
+ '../../base/base.gyp:base',
+ '../../net/net.gyp:net',
akalin 2013/10/16 07:16:31 need to depend on net directly? (don't think so)
Nicolas Zea 2013/10/16 19:56:18 Done.
+ '../../net/net.gyp:net_test_support',
+ '../../testing/gtest.gyp:gtest',
+ '../../third_party/protobuf/protobuf.gyp:protobuf_lite',
akalin 2013/10/16 07:16:31 need to depend on protobuf_lite directly? (don't t
Nicolas Zea 2013/10/16 19:56:18 Done.
+ 'gcm'
+ ],
+ 'sources': [
+ 'base/socket_stream_unittest.cc',
+ ]
+ },
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698