google_apis/gcm/base/gcm_export.h - Issue 23684017: [GCM] Initial work to set up directory structure and introduce socket integration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: google_apis/gcm/base/gcm_export.h

Issue 23684017: [GCM] Initial work to set up directory structure and introduce socket integration (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Self review Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef GOOGLE_APIS_GCM_GCM_EXPORT_H_

	6 #define GOOGLE_APIS_GCM_GCM_EXPORT_H_

	7

	8 #if defined(COMPONENT_BUILD)

	9 #if defined(WIN32)

	10

	11 #if defined(GCM_IMPLEMENTATION)

	12 #define GCM_EXPORT __declspec(dllexport)

	13 #define GCM_EXPORT_PRIVATE __declspec(dllexport)

	14 #elif defined(GCM_TEST)

	15 #define GCM_EXPORT __declspec(dllimport)

	16 #define GCM_EXPORT_PRIVATE __declspec(dllimport)
	Ryan Sleevi 2013/09/03 23:04:08 You shouldn't need a _PRIVATE export for new compo You shouldn't need a _PRIVATE export for new components See this thread at https://groups.google.com/a/chromium.org/d/msg/chromium-dev/XMDgIB2nn-0/j6WUq... Nicolas Zea 2013/09/07 01:07:52 Done. Show quoted text On 2013/09/03 23:04:08, Ryan Sleevi wrote: > You shouldn't need a _PRIVATE export for new components > > See this thread at > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/XMDgIB2nn-0/j6WUq... > Done.
	17 #else

	18 #define GCM_EXPORT __declspec(dllimport)

	19 #define GCM_EXPORT_PRIVATE

	20 #endif // defined(GCM_IMPLEMENTATION)

	21

	22 #else // defined(WIN32)

	23 #if defined(GCM_IMPLEMENTATION)

	24 #define GCM_EXPORT __attribute__((visibility("default")))

	25 #define GCM_EXPORT_PRIVATE __attribute__((visibility("default")))

	26 #elif defined(GCM_TEST)

	27 #define GCM_EXPORT

	28 #define GCM_EXPORT_PRIVATE __attribute__((visibility("default")))

	29 #else

	30 #define GCM_EXPORT

	31 #define GCM_EXPORT_PRIVATE

	32 #endif // defined(GCM_IMPLEMENTATION)

	33 #endif

	34

	35 #else // defined(COMPONENT_BUILD)

	36 #define GCM_EXPORT

	37 #define GCM_EXPORT_PRIVATE

	38 #endif

	39

	40 #endif // GOOGLE_APIS_GCM_GCM_EXPORT_H_

OLD	NEW

« no previous file with comments | « google_apis/gcm/OWNERS ('k') | google_apis/gcm/base/socket_stream.h » ('j') | google_apis/gcm/base/socket_stream.h » ('J')