Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 23684014: Crash direct wrapping media element when media isn't enabled (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, haraken, dcarney
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Call createV8HTMLFallbackWrapper instead of createV8HTMLWrapper when dispatching a disabled MediaElement wrap. If media is disabled, createV8HTMLWrapper makes a crash when media element is created. Test: fast/media/media-disable-crash.html BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159000

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A LayoutTests/fast/media/media-disable-crash.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/media-disable-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/scripts/make_names.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
Direct wrapping media makes a crash when media is disabled. Below is a crash callstack. ...
7 years, 2 months ago (2013-09-28 03:54:27 UTC) #1
gyuyoung-inactive
Add tkent to reviewer. I think we need to return a fallback wrapper instead of ...
7 years, 2 months ago (2013-10-05 14:24:45 UTC) #2
tkent
+dcarney, haraken
7 years, 2 months ago (2013-10-06 22:38:00 UTC) #3
haraken
LGTM. I agree that creating a fallback wrapper is a right thing to do here.
7 years, 2 months ago (2013-10-06 23:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23684014/9001
7 years, 2 months ago (2013-10-06 23:58:43 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 02:02:36 UTC) #6
Message was sent while issue was closed.
Change committed as 159000

Powered by Google App Engine
This is Rietveld 408576698