Allow ASan to instrument globals on Mac.

Allow ASan to instrument globals on Mac.

The corresponding upstream bug (https://code.google.com/p/address-sanitizer/issues/detail?id=171)
has been fixed by Bill Wendling in LLVM r187827

BUG=196561
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221178

[Alexander Potapenko, 2013-09-03 14:19:47]

PTAL

[Nico, 2013-09-03 15:27:01]

lgtm. Change "clang rXXX" to "llvm rXXX" in the CL description, as far as I can
tell that change is in llvm not clang.

https://codereview.chromium.org/23684013/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684013/diff/1/build/common.gypi#newcode3623
build/common.gypi:3623: '-mllvm -asan-globals=0',
This is a different bug and is still needed, right?

[Alexander Potapenko, 2013-09-03 16:21:43]

Fixed the description.
The unit_tests failure on the mac_asan trybot is unrelated to my CL
It turns out sandbox_unittests aren't being ran on the trybot, so I'll have to
double-check locally.

https://codereview.chromium.org/23684013/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23684013/diff/1/build/common.gypi#newcode3623
build/common.gypi:3623: '-mllvm -asan-globals=0',
On 2013/09/03 15:27:01, Nico wrote:
> This is a different bug and is still needed, right?

Right.

[Alexander Potapenko, 2013-09-03 16:24:42]

On 2013/09/03 16:21:43, Alexander Potapenko wrote:
> Fixed the description.
> The unit_tests failure on the mac_asan trybot is unrelated to my CL
> It turns out sandbox_unittests aren't being ran on the trybot, so I'll have to
> double-check locally.

Ah, MacSandboxTest tests listed in issue 196561 are in content_unittests and do
pass:
http://build.chromium.org/p/tryserver.chromium/builders/mac_asan/builds/41276...
Committing.

[Alexander Potapenko, 2013-09-04 12:21:41]

Committed patchset #1 manually as r221178 (presubmit successful).