Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2368393005: [tools] Fix callstats.html's first select behavior (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Improve callstats.html - Select Total group by default, this way graphs show up immediately - Groups can now be toggled much like pages and versions BUG= NOTRY=true Committed: https://crrev.com/c5c117a70d2505b937ec3ea8ad4506b485d2049a Cr-Commit-Position: refs/heads/master@{#39806}

Patch Set 1 #

Patch Set 2 : support selecting groups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
M tools/callstats.html View 1 14 chunks +70 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-28 07:00:11 UTC) #3
Igor Sheludko
lgtm
4 years, 2 months ago (2016-09-28 07:42:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368393005/20001
4 years, 2 months ago (2016-09-28 07:47:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 07:49:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 07:50:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5c117a70d2505b937ec3ea8ad4506b485d2049a
Cr-Commit-Position: refs/heads/master@{#39806}

Powered by Google App Engine
This is Rietveld 408576698