Issue 2368393002: [modules] Move implementation of Instantiate to i::Module

Issue 2368393002: [modules] Move implementation of Instantiate to i::Module (Closed)

Created:
4 years, 2 months ago by adamk

Modified:
4 years, 2 months ago

Reviewers:
neis

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[modules] Move implementation of Instantiate to i::Module This allows the CreateExport/ResolveExport methods to be private to Module. R=neis@chromium.org BUG=v8:1569 Committed: https://crrev.com/550e37296c9555b90eb6d0f7180483a9121270e1 Cr-Commit-Position: refs/heads/master@{#39738}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -112 lines)			Patch
M	src/api.cc	View	1 chunk	+2 lines, -98 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+22 lines, -14 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+88 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368393002/1

4 years, 2 months ago (2016-09-26 18:22:32 UTC) #4

commit-bot: I haz the power

4 years, 2 months ago (2016-09-26 18:50:51 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/550e37296c9555b90eb6d0f7180483a9121270e1
Cr-Commit-Position: refs/heads/master@{#39738}