Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2368373003: Check resource bitmap before calling onResourceReady (Closed)

Created:
4 years, 2 months ago by mdjones
Modified:
4 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check resource bitmap before calling onResourceReady When loading a resource, it is possible that it will not have a bitmap (OOM cases for example). This change checks that the bitmap exists in the resource before calling native OnResourceReady. BUG=650361 Committed: https://crrev.com/80c9943c67b388a35cb9b04de7c6aca81e139f2c Cr-Commit-Position: refs/heads/master@{#421283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/android/java/src/org/chromium/ui/resources/ResourceManager.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
There are a bunch of DCHECKS in the JavaBitmap constructor for errors in getting bitmap ...
4 years, 2 months ago (2016-09-27 17:15:41 UTC) #2
David Trainor- moved to gerrit
lgtm
4 years, 2 months ago (2016-09-27 17:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368373003/1
4 years, 2 months ago (2016-09-27 18:03:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 18:46:08 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:57:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80c9943c67b388a35cb9b04de7c6aca81e139f2c
Cr-Commit-Position: refs/heads/master@{#421283}

Powered by Google App Engine
This is Rietveld 408576698