Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2368363002: mustash: Fix crash when opening system tray menu (Closed)

Created:
4 years, 2 months ago by James Cook
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul, oshima
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mustash: Fix crash when opening system tray menu Mustash does not yet support KeyEventWatcher, so check for null before trying to use it. Crash was introduced in https://codereview.chromium.org/2330403002/ BUG=649600 TEST=manual Committed: https://crrev.com/ae2b5b05e17f75f7675b3fe9fe71044c0e22e278 Cr-Commit-Position: refs/heads/master@{#420931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ash/common/system/tray/system_tray.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
James Cook
msw, please take a look. I missed this while reviewing a patch from oshima. I ...
4 years, 2 months ago (2016-09-26 17:29:58 UTC) #5
msw
lgtm
4 years, 2 months ago (2016-09-26 17:59:25 UTC) #8
James Cook
+oshima, just FYI. Sorry I missed this.
4 years, 2 months ago (2016-09-26 18:03:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368363002/1
4 years, 2 months ago (2016-09-26 18:04:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:10:26 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:13:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae2b5b05e17f75f7675b3fe9fe71044c0e22e278
Cr-Commit-Position: refs/heads/master@{#420931}

Powered by Google App Engine
This is Rietveld 408576698