Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2368333003: Improve speed of 2D canvas hibernation unit tests (Closed)

Created:
4 years, 2 months ago by Justin Novosad
Modified:
4 years, 2 months ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve speed of 2D canvas hibernation unit tests The canvas hibernation mechanism uses idle task scheduling, which is desirable in the real world to prevent it from causing jank, but introduces unnecessary delays in unit tests. This change modifies Canvas2DLayerBridge to allow unit tests to request undelayed scheduling in order to execute tests faster about 100x faster than before. BUG=650344 Committed: https://crrev.com/9358c2bb26d2e91cf648d560f705038f10a4994a Cr-Commit-Position: refs/heads/master@{#421579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 4 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Justin Novosad
PTAL
4 years, 2 months ago (2016-09-26 20:08:31 UTC) #3
xlai (Olivia)
lgtm
4 years, 2 months ago (2016-09-26 21:56:54 UTC) #7
xidachen
lgtm
4 years, 2 months ago (2016-09-27 00:37:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368333003/1
4 years, 2 months ago (2016-09-28 18:20:57 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 18:27:15 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 18:28:59 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9358c2bb26d2e91cf648d560f705038f10a4994a
Cr-Commit-Position: refs/heads/master@{#421579}

Powered by Google App Engine
This is Rietveld 408576698