Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 236833009: Export [Dis]allowJavascriptExecutionScope (Closed)

Created:
6 years, 8 months ago by Devlin
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Export [Dis]allowJavascriptExecutionScope R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Devlin
We need this capability in chrome to ensure we don't trigger JS when logging.
6 years, 8 months ago (2014-04-14 17:57:16 UTC) #1
Yang
On 2014/04/14 17:57:16, D Cronin wrote: > We need this capability in chrome to ensure ...
6 years, 8 months ago (2014-04-14 17:59:03 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-14 17:59:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/rdevlin.cronin@chromium.org/236833009/1
6 years, 8 months ago (2014-04-14 17:59:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 17:59:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-14 17:59:33 UTC) #6
Yang
On 2014/04/14 17:59:03, Yang wrote: > On 2014/04/14 17:57:16, D Cronin wrote: > > We ...
6 years, 8 months ago (2014-04-14 17:59:35 UTC) #7
Yang
On 2014/04/14 17:59:35, Yang wrote: > On 2014/04/14 17:59:03, Yang wrote: > > On 2014/04/14 ...
6 years, 8 months ago (2014-04-14 18:00:25 UTC) #8
Devlin
On 2014/04/14 18:00:25, Yang wrote: > On 2014/04/14 17:59:35, Yang wrote: > > On 2014/04/14 ...
6 years, 8 months ago (2014-04-14 18:01:08 UTC) #9
Yang
6 years, 8 months ago (2014-04-14 19:34:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r20737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698