Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 236833004: Revert "Rename target-specific binaries built for host." (Closed)

Created:
6 years, 8 months ago by Torne
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Revert "Rename target-specific binaries built for host." The Android build system support for gyp has been fixed to handle target-dependent host binaries correctly without requiring them to include the target architecture in the name. Remove the suffixes to make referring to these targets simpler again. This reverts r14209. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 7 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Jakob, I'd like to undo the change I made some time ago to include ...
6 years, 8 months ago (2014-04-14 14:12:37 UTC) #1
Torne
Ping; Jakob, can we go ahead with this? It'd help me clean some stuff up ...
6 years, 7 months ago (2014-05-21 11:04:44 UTC) #2
Jakob Kummerow
LGTM, landing.
6 years, 7 months ago (2014-05-22 09:03:48 UTC) #3
Jakob Kummerow
Committed patchset #1 manually as r21428 (presubmit successful).
6 years, 7 months ago (2014-05-22 09:04:35 UTC) #4
Torne
6 years, 6 months ago (2014-06-12 16:42:46 UTC) #5
Message was sent while issue was closed.
Hi Jakob,

There's a target which still has the architecture in the name; it was introduced
after I originally prepared this patch :)

Can you rename v8_libbase.<(v8_target_arch) to v8_libbase ? We need to depend on
this as well since code is moving into it from v8_base, and so right now we're
having to go back to having architecture-specific dependencies :/

Powered by Google App Engine
This is Rietveld 408576698