Rename device_orientation to device_sensors

Rename device_orientation to device_sensors

content/{renderer, common, browser}/device_orientation ->
content/{renderer, common, browser}/device_sensors.

Rename DeviceMotionAndOrientation.java -> DeviceSensors.java

Fix the ifdef include guards
Fix Linting nits complained by cpplint.py

This change is needed to add DeviceLight api.
I will add DeviceLight related changes after https://codereview.chromium.org/143823004/
is added in Blink.

BUG=336424
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265421

[riju_, 2014-04-14 14:20:31]

Hi Tim,

In this CL, I have addressed your comments on
https://codereview.chromium.org/152893002/

Please have a look now.

Thanks,
Riju

[timvolodine, 2014-04-14 18:24:38]

cool, looks better regarding "D" and "M" designations.

https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(left):

https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:1:
// Copyright 2013 The Chromium Authors. All rights reserved.
I think there is also DeviceMotionAndOrientationTest.java somewhere...

[riju_, 2014-04-15 12:33:27]

+ jochen@chromium.org as Content Owner

[riju_, 2014-04-15 12:52:06]

On 2014/04/14 18:24:38, timvolodine wrote:
> cool, looks better regarding "D" and "M" designations.
> 
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
> (left):
> 
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:1:
> // Copyright 2013 The Chromium Authors. All rights reserved.
> I think there is also DeviceMotionAndOrientationTest.java somewhere...

Tim : Yes, Done now. Renamed to DeviceSensorsTest.java

Since android_dbg_trigger_tests is failing in the bots (unit_tests), i locally
ran ->
ninja -C out/Release android_builder_tests
build/android/test_runner.py gtest -s unit_tests --release -vvv

Locally it was working fine. 

.......
.......
[----------] 2 tests from
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest
[ RUN      ]
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest.GetLastUsedProfileAllowedByPolicy/0
[       OK ]
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest.GetLastUsedProfileAllowedByPolicy/0
(7 ms)
[ RUN      ]
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest.GetLastUsedProfileAllowedByPolicy/1
[       OK ]
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest.GetLastUsedProfileAllowedByPolicy/1
(6 ms)
[----------] 2 tests from
ProfileManagerGuestTestInstantiation/ProfileManagerGuestTest (14 ms total)

[----------] Global test environment tear-down
[==========] 3241 tests from 512 test cases ran. (152470 ms total)
[  PASSED  ] 3241 tests.

  YOU HAVE 16 DISABLED TESTS

I  200s f537  [f537]> pm path org.chromium.native_test
I  200s f537  [f537]> pm clear org.chromium.native_test
C  201s Main 
********************************************************************************
C  201s Main  Summary
C  201s Main 
********************************************************************************
C  201s Main  ALL (3241 tests)
C  201s Main  PASS (3241 tests)
C  201s Main  FAIL (0 tests): []
C  201s Main  CRASH (0 tests): []
C  201s Main  TIMEOUT (0 tests): []
C  201s Main  UNKNOWN (0 tests): []
C  201s Main 
********************************************************************************

[timvolodine, 2014-04-15 13:03:17]

On 2014/04/15 12:52:06, riju_ wrote:
> On 2014/04/14 18:24:38, timvolodine wrote:
> > cool, looks better regarding "D" and "M" designations.
> > 
> >
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
> > File
> >
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
> > (left):
> > 
> >
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
> >
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:1:
> > // Copyright 2013 The Chromium Authors. All rights reserved.
> > I think there is also DeviceMotionAndOrientationTest.java somewhere...
> 
> Tim : Yes, Done now. Renamed to DeviceSensorsTest.java
> 
> Since android_dbg_trigger_tests is failing in the bots (unit_tests), i locally
> ran ->
> ninja -C out/Release android_builder_tests
> build/android/test_runner.py gtest -s unit_tests --release -vvv
> 

those are instrumentation tests, normally run by:
ninja -C out/Debug -j20 chrome_apk content_shell_apk content_shell_test_apk
build/android/test_runner.py instrumentation --test-apk=ContentShellTest -f
DeviceSensorsTest*

[riju_, 2014-04-15 13:40:41]

On 2014/04/15 13:03:17, timvolodine wrote:
> On 2014/04/15 12:52:06, riju_ wrote:
> > On 2014/04/14 18:24:38, timvolodine wrote:
> > > cool, looks better regarding "D" and "M" designations.
> > > 
> > >
> >
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
> > > File
> > >
> >
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
> > > (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/236833003/diff/1/content/public/android/java/...
> > >
> >
>
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:1:
> > > // Copyright 2013 The Chromium Authors. All rights reserved.
> > > I think there is also DeviceMotionAndOrientationTest.java somewhere...
> > 
> > Tim : Yes, Done now. Renamed to DeviceSensorsTest.java
> > 
> > Since android_dbg_trigger_tests is failing in the bots (unit_tests), i
locally
> > ran ->
> > ninja -C out/Release android_builder_tests
> > build/android/test_runner.py gtest -s unit_tests --release -vvv
> > 
> 
> those are instrumentation tests, normally run by:
> ninja -C out/Debug -j20 chrome_apk content_shell_apk content_shell_test_apk
> build/android/test_runner.py instrumentation --test-apk=ContentShellTest -f
> DeviceSensorsTest*

Ok, so i used Release build locally (device = Nexus 5)
build/android/test_runner.py instrumentation --test-apk=ContentShellTest -f
DeviceSensors* --release
...
...
# 04/15/14 16:38:31: am instrument -e class
'org.chromium.content.browser.DeviceSensorsTest#testUnregisterSensorsDeviceMotion'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 04/15/14 16:38:32: am instrument -e class
'org.chromium.content.browser.DeviceSensorsTest#testRegisterSensorsDeviceMotion'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 04/15/14 16:38:32: am instrument -e class
'org.chromium.content.browser.DeviceSensorsTest#testUnRegisterSensorsDeviceMotionAndOrientation'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 04/15/14 16:38:33: am instrument -e class
'org.chromium.content.browser.DeviceSensorsTest#testSensorChangedgotAcceleration'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
# 04/15/14 16:38:34: am instrument -e class
'org.chromium.content.browser.DeviceSensorsTest#testSensorChangedgotRotationRate'
-r -w
org.chromium.content_shell_apk.tests/android.test.InstrumentationTestRunner
C   21s Main 
********************************************************************************
C   21s Main  Summary
C   21s Main 
********************************************************************************
C   21s Main  ALL (18 tests)
C   21s Main  PASS (18 tests)
C   21s Main  FAIL (0 tests): []
C   21s Main  CRASH (0 tests): []
C   21s Main  TIMEOUT (0 tests): []
C   21s Main  UNKNOWN (0 tests): []
C   21s Main 
********************************************************************************

[timvolodine, 2014-04-15 13:53:18]

lgtm

great!

[riju_, 2014-04-15 14:02:19]

On 2014/04/15 13:53:18, timvolodine wrote:
> lgtm
> 
> great!

thanks!

[jochen (gone - plz use gerrit), 2014-04-16 09:10:47]

can you please reference a tracking bug from the CL description?

rubberstamp lgtm for renaming stuff

[riju_, 2014-04-16 09:17:19]

On 2014/04/16 09:10:47, jochen wrote:
> can you please reference a tracking bug from the CL description?
> 
> rubberstamp lgtm for renaming stuff

Tracking Bug added.
Thanks.

[riju_, 2014-04-16 09:24:07]

+dcheng@chromium.org content/common owner

[dcheng, 2014-04-22 18:26:23]

content/common/*message* LGTM

[dcheng, 2014-04-22 18:26:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-04-22 18:31:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/236833003/...

[commit-bot: I haz the power, 2014-04-22 23:48:57]

Change committed as 265421