Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2368303002: Revert of VariableProxy: when cloning, don't even think about creating dangling references. (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of VariableProxy: when cloning, don't even think about creating dangling references. (patchset #1 id:1 of https://codereview.chromium.org/2368253002/ ) Reason for revert: Needed for https://codereview.chromium.org/2373443003/ Original issue's description: > VariableProxy: when cloning, don't even think about creating dangling references. > > The code path for cloning resolved VariableProxys (into a different > Zone) was never hit, but if it was, it would create a dangling > reference, since the Variable would stay in the original Zone. > > Kudos to verwaest@ for finding this! > > R=verwaest@chromium.org > BUG= > > Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c > Cr-Commit-Position: refs/heads/master@{#39723} TBR=verwaest@chromium.org,marja@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8edf2905693a2b486a97a0547ec53bb552f7db15 Cr-Commit-Position: refs/heads/master@{#39726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/ast/ast.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of VariableProxy: when cloning, don't even think about creating dangling references.
4 years, 2 months ago (2016-09-26 13:56:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368303002/1
4 years, 2 months ago (2016-09-26 13:56:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 13:56:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8edf2905693a2b486a97a0547ec53bb552f7db15 Cr-Commit-Position: refs/heads/master@{#39726}
4 years, 2 months ago (2016-09-26 13:56:52 UTC) #6
Michael Hablich
4 years, 2 months ago (2016-09-26 14:01:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2366373002/ by hablich@chromium.org.

The reason for reverting is: wrong CL.

Powered by Google App Engine
This is Rietveld 408576698