Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23683002: Remove ibus_panel_service.cc and related files. (Closed)

Created:
7 years, 3 months ago by Hiro Komatsu
Modified:
7 years, 3 months ago
Reviewers:
satorux1, Seigo Nonaka
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ibus_panel_service.cc and related files. BUG=280438 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1259 lines) Patch
M chromeos/chromeos.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chromeos/dbus/ibus/ibus_panel_service.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chromeos/dbus/ibus/ibus_panel_service.cc View 1 chunk +0 lines, -457 lines 0 comments Download
D chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 1 chunk +0 lines, -634 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_panel_service.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chromeos/dbus/ibus/mock_ibus_panel_service.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Hiro Komatsu
This CL depends on https://codereview.chromium.org/23680003/
7 years, 3 months ago (2013-08-29 01:47:19 UTC) #1
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-08-29 04:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23683002/1
7 years, 3 months ago (2013-08-30 11:01:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=23191
7 years, 3 months ago (2013-08-30 11:14:37 UTC) #4
Hiro Komatsu
Satoru, can you give your LGTM for chromeos/chromeos.gyp?
7 years, 3 months ago (2013-09-02 01:25:12 UTC) #5
satorux1
LGTM. Keep removing!
7 years, 3 months ago (2013-09-02 01:41:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/komatsu@chromium.org/23683002/1
7 years, 3 months ago (2013-09-02 01:45:00 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:48:37 UTC) #8
Message was sent while issue was closed. 
Change committed as 220812

Powered by Google App Engine
This is Rietveld 408576698