My take on SkAlign changes.

My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002

No public API changes.
TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c

[mtklein_C, 2016-09-26 13:51:02]

Description was changed from

==========
My take on SkAlign changes.

BUG=skia:
==========

to

==========
My take on SkAlign changes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 13:53:34]

Description was changed from

==========
My take on SkAlign changes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign(x, N).

We can decide if we want to keep the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 13:56:45]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 13:56:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-26 14:05:40]

Description was changed from

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign(x, N).

We can decide if we want to keep the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign<N>(x).

We can decide if we want to keep the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 14:08:51]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 14:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-26 14:09:17]

Description was changed from

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign<N>(x).

We can decide if we want to keep the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign<N>(x).

We can decide if we want to sed away the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 14:22:08]

Description was changed from

==========
My take on SkAlign changes.

This makes SkAlignN(x) macros work for pointers, and makes the macros themselves
just syntax sugar for SkAlign<N>(x).

We can decide if we want to sed away the macros independently.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat more compact way.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 14:22:38]

Description was changed from

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat more compact way.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 14:23:03]

Description was changed from

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

[mtklein_C, 2016-09-26 14:23:29]

mtklein@chromium.org changed reviewers:
+ cblume@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:35:10]

Dry run: This issue passed the CQ dry run.

[cblume, 2016-09-26 17:13:47]

On 2016/09/26 14:23:29, mtklein_C wrote:

I'm cool with this method. It is roughly the same idea as what I wrote.
I like how it casts the type to uintptr_t which means you don't need separate
versions for pointers and non-pointers.

lgtm

[mtklein_C, 2016-09-26 17:21:04]

> I like how it casts the type to uintptr_t which means you don't need separate
versions for pointers and non-pointers.

Just so we're clear, it does have different versions for pointers and
non-pointers.
The version for pointers is, cast to uintptr_t, use that, then cast back.
All other types are aligned in their native type, not uintptr_t.

[mtklein_C, 2016-09-26 17:26:52]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:27:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-26 17:27:12]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-09-26 17:27:24]

Description was changed from

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002
==========

to

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002

No public API changes.
TBR=reed@google.com
==========

[mtklein_C, 2016-09-26 17:27:27]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:31:14]

Description was changed from

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002

No public API changes.
TBR=reed@google.com
==========

to

==========
My take on SkAlign changes.

Like the other change, it makes SkAlignN(x) macros work for pointers, and makes
the macros themselves just syntax sugar for SkAlign<N>(x).  We can still decide
if we want to sed away the macros independently.

This just does it in a somewhat less repetitive way, and adds some tests.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002

No public API changes.
TBR=reed@google.com

Committed:
https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c
==========

[commit-bot: I haz the power, 2016-09-26 17:31:15]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c

[mtklein, 2016-09-27 01:20:49]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2372083002/ by mtklein@google.com.

The reason for reverting is: Let's see if reverting this helps the roll..