views: add focus to TabbedPane

ui/views/focus/focus_traversal_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 15 matching lines @@
 #include "ui/views/test/focus_manager_test.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget.h"
 
 using base::ASCIIToUTF16;
 
 namespace views {
 
 namespace {
 
-int count = 1;
+enum {

[sky, 2016/10/05 20:00:22]

enum style for chrome is ALL_CAPS.

[Elly Fong-Jones, 2016/10/06 16:15:30]

This is done... but at what cost??

[sky, 2016/10/06 21:14:40]

Consistency?

+  kTopCheckBoxID = 1,  // 1
+  kLeftContainerID,
+  kAppleLabelID,
+  kAppleTextfieldID,
+  kOrangeLabelID,  // 5
+  kOrangeTextfieldID,
+  kBananaLabelID,
+  kBananaTextfieldID,
+  kKiwiLabelID,
+  kKiwiTextfieldID,  // 10
+  kFruitButtonID,
+  kFruitCheckBoxID,
+  kComboboxID,
 
-const int kTopCheckBoxID = count++;  // 1
-const int kLeftContainerID = count++;
-const int kAppleLabelID = count++;
-const int kAppleTextfieldID = count++;
-const int kOrangeLabelID = count++;  // 5
-const int kOrangeTextfieldID = count++;
-const int kBananaLabelID = count++;
-const int kBananaTextfieldID = count++;
-const int kKiwiLabelID = count++;
-const int kKiwiTextfieldID = count++;  // 10
-const int kFruitButtonID = count++;
-const int kFruitCheckBoxID = count++;
-const int kComboboxID = count++;
+  kRightContainerID,
+  kAsparagusButtonID,  // 15
+  kBroccoliButtonID,
+  kCauliflowerButtonID,
 
-const int kRightContainerID = count++;
-const int kAsparagusButtonID = count++;  // 15
-const int kBroccoliButtonID = count++;
-const int kCauliflowerButtonID = count++;
+  kInnerContainerID,
+  kScrollViewID,
+  kRosettaLinkID,  // 20
+  kStupeurEtTremblementLinkID,
+  kDinerGameLinkID,
+  kRidiculeLinkID,
+  kClosetLinkID,
+  kVisitingLinkID,  // 25
+  kAmelieLinkID,
+  kJoyeuxNoelLinkID,
+  kCampingLinkID,
+  kBriceDeNiceLinkID,
+  kTaxiLinkID,  // 30
+  kAsterixLinkID,
 
-const int kInnerContainerID = count++;
-const int kScrollViewID = count++;
-const int kRosettaLinkID = count++;  // 20
-const int kStupeurEtTremblementLinkID = count++;
-const int kDinerGameLinkID = count++;
-const int kRidiculeLinkID = count++;
-const int kClosetLinkID = count++;
-const int kVisitingLinkID = count++;  // 25
-const int kAmelieLinkID = count++;
-const int kJoyeuxNoelLinkID = count++;
-const int kCampingLinkID = count++;
-const int kBriceDeNiceLinkID = count++;
-const int kTaxiLinkID = count++;  // 30
-const int kAsterixLinkID = count++;
+  kOKButtonID,
+  kCancelButtonID,
+  kHelpButtonID,
 
-const int kOKButtonID = count++;
-const int kCancelButtonID = count++;
-const int kHelpButtonID = count++;
+  kStyleContainerID,  // 35
+  kBoldCheckBoxID,
+  kItalicCheckBoxID,
+  kUnderlinedCheckBoxID,
+  kStyleHelpLinkID,
+  kStyleTextEditID,  // 40
 
-const int kStyleContainerID = count++;  // 35
-const int kBoldCheckBoxID = count++;
-const int kItalicCheckBoxID = count++;
-const int kUnderlinedCheckBoxID = count++;
-const int kStyleHelpLinkID = count++;
-const int kStyleTextEditID = count++;  // 40
+  kSearchContainerID,
+  kSearchTextfieldID,
+  kSearchButtonID,
+  kHelpLinkID,
 
-const int kSearchContainerID = count++;
-const int kSearchTextfieldID = count++;
-const int kSearchButtonID = count++;
-const int kHelpLinkID = count++;
-
-const int kThumbnailContainerID = count++;  // 45
-const int kThumbnailStarID = count++;
-const int kThumbnailSuperStarID = count++;
+  kThumbnailContainerID,  // 45
+  kThumbnailStarID,
+  kThumbnailSuperStarID,
+};
 
 class DummyComboboxModel : public ui::ComboboxModel {
  public:
   // Overridden from ui::ComboboxModel:
   int GetItemCount() const override { return 10; }
   base::string16 GetItemAt(int index) override {
     return ASCIIToUTF16("Item ") + base::IntToString16(index);
   }
 };
 
@@ skipping 84 matching lines @@
   void InitContentView() override;
 
  protected:
   FocusTraversalTest();
 
   View* FindViewByID(int id) {
     View* view = GetContentsView()->GetViewByID(id);
     if (view)
       return view;
     if (style_tab_)
-      view = style_tab_->GetSelectedTab()->GetViewByID(id);
+      view = style_tab_->GetSelectedTabViewForTesting()->GetViewByID(id);
     if (view)
       return view;
     view = search_border_view_->GetContentsRootView()->GetViewByID(id);
     if (view)
       return view;
     return NULL;
   }
 
  protected:
   // Helper function to advance focus multiple times in a loop. |traversal_ids|
@@ skipping 309 matching lines @@
   contents->AddChildView(link);
   link->SetBounds(10, 35, 70, 10);
   link->set_id(kStyleHelpLinkID);
 
   text_field = new Textfield();
   contents->AddChildView(text_field);
   text_field->SetBounds(10, 50, 100, 20);
   text_field->set_id(kStyleTextEditID);
 
   style_tab_ = new TabbedPane();
-  style_tab_->set_id(kStyleContainerID);
   GetContentsView()->AddChildView(style_tab_);
   style_tab_->SetBounds(10, y, 210, 100);
   style_tab_->AddTab(ASCIIToUTF16("Style"), contents);
+  style_tab_->GetSelectedTabForTesting()->set_id(kStyleContainerID);
   style_tab_->AddTab(ASCIIToUTF16("Other"), new View());
 
   // Right bottom box with search.
   contents = new View();
   contents->set_background(Background::CreateSolidBackground(SK_ColorWHITE));
   text_field = new Textfield();
   contents->AddChildView(text_field);
   text_field->SetBounds(10, 10, 100, 20);
   text_field->set_id(kSearchTextfieldID);
 
@@ skipping 300 matching lines @@
   GetFocusManager()->AdvanceFocus(false);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 
   // Advance backwards from the root node.
   GetFocusManager()->ClearFocus();
   GetFocusManager()->AdvanceFocus(true);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 }
 
 }  // namespace views