Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2368273002:
Typo? (Closed)
|
Created:
4 years, 2 months ago by mtklein_C Modified:
4 years, 2 months ago Reviewers:
csmartdalton CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionTypo?
This can't be what you intended...
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/8b4a2026fd4edd722d79c90a84000ab720622d71
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
Description was changed from ========== Typo? This can't be what you intended... BUG=skia: ========== to ========== Typo? This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 ==========
mtklein@chromium.org changed reviewers: + csmartdalton@google.com
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-09-26 19:16 UTC
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
Patchset #2 (id:20001) has been deleted
lgtm Is there an issue with the old code, besides readability?
On 2016/09/26 at 14:42:09, csmartdalton wrote: > lgtm > > Is there an issue with the old code, besides readability? No, I don't think so. You'd get some sort of "can't assign void to int" error if this were somehow parsed the other way. The main thing here is to make it clear you didn't intend it to be parsed that way.
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Typo? This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 ========== to ========== Typo? This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 NOTREECHECKS=true ==========
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Typo? This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 NOTREECHECKS=true ========== to ========== Typo? This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/8b4a2026fd4edd722d79c90a84000ab720622d71 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8b4a2026fd4edd722d79c90a84000ab720622d71 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
