Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2368263003: Convert editing/selection/document-mutation.html to use w3c test harness (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/document-mutation.html to use w3c test harness This patch converts "editing/selection/document-mutation.html" to use w3c test harness to simplify test case for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/e6a38be833c08272f2aa356601ff663078876553 Cr-Commit-Position: refs/heads/master@{#421180}

Patch Set 1 : 2016-09-27T13:18:44 #

Total comments: 2

Patch Set 2 : 2016-09-27T18:54:28 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -119 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/document-mutation.html View 1 1 chunk +75 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/document-mutation-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
yosin_UTC9
PTAL
4 years, 2 months ago (2016-09-27 08:45:51 UTC) #7
Xiaocheng
lgtm with a nit. https://codereview.chromium.org/2368263003/diff/1/third_party/WebKit/LayoutTests/editing/selection/document-mutation.html File third_party/WebKit/LayoutTests/editing/selection/document-mutation.html (right): https://codereview.chromium.org/2368263003/diff/1/third_party/WebKit/LayoutTests/editing/selection/document-mutation.html#newcode24 third_party/WebKit/LayoutTests/editing/selection/document-mutation.html:24: function doDelete(selection, start, end) { ...
4 years, 2 months ago (2016-09-27 09:32:50 UTC) #8
yosin_UTC9
Thanks! https://codereview.chromium.org/2368263003/diff/1/third_party/WebKit/LayoutTests/editing/selection/document-mutation.html File third_party/WebKit/LayoutTests/editing/selection/document-mutation.html (right): https://codereview.chromium.org/2368263003/diff/1/third_party/WebKit/LayoutTests/editing/selection/document-mutation.html#newcode24 third_party/WebKit/LayoutTests/editing/selection/document-mutation.html:24: function doDelete(selection, start, end) { On 2016/09/27 at ...
4 years, 2 months ago (2016-09-27 09:56:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368263003/20001
4 years, 2 months ago (2016-09-27 09:56:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 12:24:52 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:28:50 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6a38be833c08272f2aa356601ff663078876553
Cr-Commit-Position: refs/heads/master@{#421180}

Powered by Google App Engine
This is Rietveld 408576698