Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2368253002:
VariableProxy: when cloning, don't even think about creating dangling references. (Closed)
|
Created:
4 years, 2 months ago by marja Modified:
4 years, 2 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionVariableProxy: when cloning, don't even think about creating dangling references.
The code path for cloning resolved VariableProxys (into a different
Zone) was never hit, but if it was, it would create a dangling
reference, since the Variable would stay in the original Zone.
Kudos to verwaest@ for finding this!
R=verwaest@chromium.org
BUG=
Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c
Cr-Commit-Position: refs/heads/master@{#39723}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by marja@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. R=verwaest@chromium.org BUG= ========== to ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= ==========
ptal
lgtm
The CQ bit was unchecked by marja@chromium.org
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= ========== to ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= ========== to ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c Cr-Commit-Position: refs/heads/master@{#39723} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c Cr-Commit-Position: refs/heads/master@{#39723}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2368303002/ by hablich@chromium.org. The reason for reverting is: Needed for https://codereview.chromium.org/2373443003/.
Message was sent while issue was closed.
... shouldn't be needed for reverting. I'm re-landing this.
Message was sent while issue was closed.
Description was changed from ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c Cr-Commit-Position: refs/heads/master@{#39723} ========== to ========== VariableProxy: when cloning, don't even think about creating dangling references. The code path for cloning resolved VariableProxys (into a different Zone) was never hit, but if it was, it would create a dangling reference, since the Variable would stay in the original Zone. Kudos to verwaest@ for finding this! R=verwaest@chromium.org BUG= Committed: https://crrev.com/fd429bdb9e70cb8c4f8a4bbef0806e008c60440c Cr-Commit-Position: refs/heads/master@{#39723} ==========
The CQ bit was checked by marja@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25050)
Ahh, hablich@ already relanded :) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
