Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 236823003: Reland "Handlify Runtime::InitializeIntrinsicFunctionNames." (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reland "Handlify Runtime::InitializeIntrinsicFunctionNames." R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20738

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -60 lines) Patch
M src/factory.cc View 1 2 chunks +1 line, -12 lines 0 comments Download
M src/heap.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/objects.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 8 chunks +18 lines, -18 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +11 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Second patchset is the fix. Apparently polymorphic functions across class inheritance including templates don't play ...
6 years, 8 months ago (2014-04-14 12:04:53 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 8 months ago (2014-04-14 14:17:09 UTC) #2
Yang
6 years, 8 months ago (2014-04-14 19:38:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20738 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698