Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2368213003: Polish plugin placeholder strings. (Closed)

Created:
4 years, 2 months ago by waffles
Modified:
4 years, 2 months ago
Reviewers:
hwi1, hwi, blundell
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polish plugin placeholder strings. BUG=643757 Committed: https://crrev.com/4e415c122158b74514a8ccdf6d114d9c302edcbb Cr-Commit-Position: refs/heads/master@{#422221}

Patch Set 1 : Ready for Review #

Patch Set 2 : Through #11\ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +17 lines, -17 lines 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
waffles
PTAL at this small change to update some plugin placeholder strings.
4 years, 2 months ago (2016-09-26 23:08:38 UTC) #7
blundell
//components lgtm
4 years, 2 months ago (2016-09-27 07:31:06 UTC) #10
hwi1
On 2016/09/27 07:31:06, blundell (OOO until Oct 3) wrote: > //components lgtm The following doesn't ...
4 years, 2 months ago (2016-09-30 19:52:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2368213003/40001
4 years, 2 months ago (2016-09-30 20:18:32 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-09-30 21:16:28 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 21:19:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e415c122158b74514a8ccdf6d114d9c302edcbb
Cr-Commit-Position: refs/heads/master@{#422221}

Powered by Google App Engine
This is Rietveld 408576698