Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23682005: Make CSSRuleList.item() index argument mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Visibility:
Public.

Description

Make CSSRuleList.item() index argument mandatory Make CSSRuleList.item() index argument mandatory to match the specification: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSRuleList This behavior is consistent with Firefox 23 and IE10. It is confusing what should be returned if the index is omitted. BUG= R=arv@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157069

Patch Set 1 #

Patch Set 2 : Rebase on master #

Patch Set 3 : Rebase on master #

Patch Set 4 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/fast/css/webkit-keyframes-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSRuleList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
do-not-use
Validated on Firefox and IE using: http://jsfiddle.net/r4e5x/8/
7 years, 3 months ago (2013-08-30 11:23:27 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 3 months ago (2013-08-30 14:34:10 UTC) #2
tkent
lgtm
7 years, 3 months ago (2013-09-02 02:23:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23682005/4001
7 years, 3 months ago (2013-09-02 02:23:58 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/css/webkit-keyframes-crash.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-02 02:24:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23682005/10001
7 years, 3 months ago (2013-09-02 06:29:28 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/css/webkit-keyframes-crash.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-02 06:29:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23682005/13001
7 years, 3 months ago (2013-09-02 08:22:51 UTC) #8
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/css/webkit-keyframes-crash.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-02 08:22:54 UTC) #9
do-not-use
7 years, 3 months ago (2013-09-02 08:23:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 manually as r157069 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698