Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: device/generic_sensor/platform_sensor_provider_base.cc

Issue 2368193003: [sensors] Introduce asynchronous way to create sensors. (Closed)
Patch Set: A comment from Mikhail Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor_provider_base.cc
diff --git a/device/generic_sensor/platform_sensor_provider_base.cc b/device/generic_sensor/platform_sensor_provider_base.cc
index 51c60ac5ae25e681cefa83ed2cdec325ee9d9ccc..4447cea93390f47f19655eaafcec4aae56e58c51 100644
--- a/device/generic_sensor/platform_sensor_provider_base.cc
+++ b/device/generic_sensor/platform_sensor_provider_base.cc
@@ -22,29 +22,36 @@ const uint64_t kSharedBufferSizeInBytes =
PlatformSensorProviderBase::PlatformSensorProviderBase() = default;
PlatformSensorProviderBase::~PlatformSensorProviderBase() = default;
-scoped_refptr<PlatformSensor> PlatformSensorProviderBase::CreateSensor(
+void PlatformSensorProviderBase::CreateSensor(
mojom::SensorType type,
uint64_t size,
- uint64_t offset) {
+ uint64_t offset,
+ const CreateSensorCallback& callback) {
DCHECK(CalledOnValidThread());
- if (!CreateSharedBufferIfNeeded())
- return nullptr;
+ if (!CreateSharedBufferIfNeeded()) {
+ callback.Run(nullptr);
+ return;
+ }
mojo::ScopedSharedBufferMapping mapping =
shared_buffer_handle_->MapAtOffset(size, offset);
- if (!mapping)
- return nullptr;
-
- scoped_refptr<PlatformSensor> new_sensor =
- CreateSensorInternal(type, std::move(mapping), size);
- if (!new_sensor)
- return nullptr;
-
- DCHECK(!ContainsKey(sensor_map_, type));
- sensor_map_[type] = new_sensor.get();
-
- return new_sensor;
+ if (!mapping) {
+ callback.Run(nullptr);
+ return;
+ }
+
+ auto it = requests_map_.find(type);
+ if (it != requests_map_.end()) {
+ it->second.push_back(callback);
+ } else {
+ requests_map_[type] = CallbackQueue({callback});
+
+ CreateSensorInternal(
+ type, std::move(mapping), size,
+ base::Bind(&PlatformSensorProviderBase::NotifySensorCreated,
+ base::Unretained(this), type));
+ }
}
scoped_refptr<PlatformSensor> PlatformSensorProviderBase::GetSensor(
@@ -83,4 +90,23 @@ PlatformSensorProviderBase::CloneSharedBufferHandle() {
return shared_buffer_handle_->Clone();
}
+void PlatformSensorProviderBase::NotifySensorCreated(
+ mojom::SensorType type,
+ scoped_refptr<PlatformSensor> sensor) {
+ DCHECK(CalledOnValidThread());
+ DCHECK(!ContainsKey(sensor_map_, type));
+ DCHECK(ContainsKey(requests_map_, type));
+
+ if (sensor)
+ sensor_map_[type] = sensor.get();
+
+ // Inform subscribers about the sensor.
+ // |sensor| can be nullptr here.
+ auto it = requests_map_.find(type);
+ for (auto& callback : it->second)
+ callback.Run(sensor);
+
+ requests_map_.erase(type);
+}
+
} // namespace device
« no previous file with comments | « device/generic_sensor/platform_sensor_provider_base.h ('k') | device/generic_sensor/platform_sensor_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698