Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: device/generic_sensor/platform_sensor_provider_android.cc

Issue 2368193003: [sensors] Introduce asynchronous way to create sensors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/generic_sensor/platform_sensor_provider_android.cc
diff --git a/device/generic_sensor/platform_sensor_provider_android.cc b/device/generic_sensor/platform_sensor_provider_android.cc
index 4009512cef3112eb524268ce46102ce61fde3d25..19c700c338f990f86717eb0f14666a759aad68a8 100644
--- a/device/generic_sensor/platform_sensor_provider_android.cc
+++ b/device/generic_sensor/platform_sensor_provider_android.cc
@@ -23,10 +23,10 @@ class PlatformSensorProviderAndroid : public PlatformSensorProvider {
static PlatformSensorProviderAndroid* GetInstance();
protected:
- scoped_refptr<PlatformSensor> CreateSensorInternal(
- mojom::SensorType type,
- mojo::ScopedSharedBufferMapping mapping,
- uint64_t buffer_size) override;
+ void CreateSensorInternal(mojom::SensorType type,
+ mojo::ScopedSharedBufferMapping mapping,
+ uint64_t buffer_size,
+ const CreateSensorCallback& callback) override;
private:
// Java object org.chromium.device.sensors.PlatformSensorProvider
@@ -55,20 +55,22 @@ PlatformSensorProviderAndroid::PlatformSensorProviderAndroid() {
PlatformSensorProviderAndroid::~PlatformSensorProviderAndroid() = default;
-scoped_refptr<PlatformSensor>
-PlatformSensorProviderAndroid::CreateSensorInternal(
+void PlatformSensorProviderAndroid::CreateSensorInternal(
mojom::SensorType type,
mojo::ScopedSharedBufferMapping mapping,
- uint64_t buffer_size) {
+ uint64_t buffer_size,
+ const CreateSensorCallback& callback) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> sensor = Java_PlatformSensorProvider_createSensor(
env, j_object_.obj(), static_cast<jint>(type));
if (!sensor.obj())
- return nullptr;
+ callback.Run(nullptr);
- return new PlatformSensorAndroid(type, std::move(mapping), buffer_size, this,
- sensor);
+ scoped_refptr<PlatformSensorAndroid> concrete_sensor =
+ new PlatformSensorAndroid(type, std::move(mapping), buffer_size, this,
+ sensor);
+ callback.Run(concrete_sensor);
}
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698